Skip to content

Improve bottom navigation bar logic#2066

Merged
hjiangsu merged 2 commits intodevelopfrom
fix/bottom-nav-bar
Mar 17, 2026
Merged

Improve bottom navigation bar logic#2066
hjiangsu merged 2 commits intodevelopfrom
fix/bottom-nav-bar

Conversation

@hjiangsu
Copy link
Member

Pull Request Description

This PR improves the bottom navigation bar logic by splitting up the gesture-related logic into its own widget ThunderBottomNavigationBar. The custom navigation bar now handles long-press, double-tap, and swipe gestures.

By implementing our own long-press detection logic, this PR also fixes a regression where long-pressing on the account tab would not trigger the profile modal to show up. We previously relied on some Flutter-specific logic (in particular, disabling the NavigationDestination's tooltip) to enable the long-press action to trigger. However, there was a regression in the behaviour in Flutter 3.41.x which caused the tooltip to render an empty string. This has been fixed upstream but has not yet made it to a release.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu merged commit 9faf322 into develop Mar 17, 2026
1 check passed
@hjiangsu hjiangsu deleted the fix/bottom-nav-bar branch March 17, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant