Improve bottom navigation bar logic#2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR improves the bottom navigation bar logic by splitting up the gesture-related logic into its own widget
ThunderBottomNavigationBar. The custom navigation bar now handles long-press, double-tap, and swipe gestures.By implementing our own long-press detection logic, this PR also fixes a regression where long-pressing on the account tab would not trigger the profile modal to show up. We previously relied on some Flutter-specific logic (in particular, disabling the
NavigationDestination's tooltip) to enable the long-press action to trigger. However, there was a regression in the behaviour in Flutter 3.41.x which caused the tooltip to render an empty string. This has been fixed upstream but has not yet made it to a release.Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?